Skip to content

Add vertical padding to article details’ right-hand side container#2463

Open
sssoz wants to merge 1 commit intoDOAJ:masterfrom
sssoz:hotfix/add-padding-to-asides
Open

Add vertical padding to article details’ right-hand side container#2463
sssoz wants to merge 1 commit intoDOAJ:masterfrom
sssoz:hotfix/add-padding-to-asides

Conversation

@sssoz
Copy link
Copy Markdown
Contributor

@sssoz sssoz commented Mar 26, 2025

[No linked issue]


Add vertical padding to article details’ right-hand side container

I noticed there was a lack of spacing (padding) on the article detail pages’ 'aside' container (which contains some article metadata on its journal). It’s been bothering me and after seeing a screenshot of a DOAJ page on social media, I decided that it was time to fix it :)

This only affects the article pages. I've created a class using the BEM naming style, .article-details__aside, to target this particular element, which had no other classes before.

Before After
Screenshot 2025-03-26 at 15 20 28 Screenshot 2025-03-26 at 15 20 13

This PR...

  • has scripts to run — I think the stylesheets just need to be recompiled
  • has migrations to run
  • adds new infrastructure
  • changes the CI pipeline
  • affects the public site
  • affects the editorial area
  • affects the publisher area
  • affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run by reviewers

Deployment

What deployment considerations are there? (delete any sections you don't need)

Configuration changes

What configuration changes are included in this PR, and do we need to set specific values for production

Scripts

What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).

Migrations

What migrations need to be run to deploy this

Monitoring

What additional monitoring is required of the application as a result of this feature

New Infrastructure

What new infrastructure does this PR require (e.g. new services that need to run on the back-end).

Continuous Integration

What CI changes are required for this

@dommitchell
Copy link
Copy Markdown
Contributor

Thank you so much! @sssoz 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants