Replace mocks with API hooks #15
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,47 @@ | ||
| import { useState, useEffect } from 'react' | ||
| import type { PasswordEntry } from '@/types/password-entry' | ||
|
|
||
| function computeStrength(password: string): 'weak' | 'medium' | 'strong' { | ||
| if (password.length > 12 && /[A-Z]/.test(password) && /[^A-Za-z0-9]/.test(password)) return 'strong' | ||
| if (password.length >= 8) return 'medium' | ||
| return 'weak' | ||
| } | ||
|
|
||
| export function useCredentials(userId: string) { | ||
| const [credentials, setCredentials] = useState<PasswordEntry[]>([]) | ||
| const [isLoading, setIsLoading] = useState(true) | ||
|
|
||
| useEffect(() => { | ||
| async function fetchCredentials() { | ||
| try { | ||
| const url = new URL(`${process.env.NEXT_PUBLIC_API_URL}/users/credentials`) | ||
| url.searchParams.append('user_id', userId) | ||
| const res = await fetch(url.toString(), { cache: 'no-store' }) | ||
| if (!res.ok) { | ||
| throw new Error('Erreur lors de la récupération des credentials') | ||
| } | ||
| const data = await res.json() | ||
| const mapped = data.map((c: any) => ({ | ||
| id: c.id, | ||
| title: c.title, | ||
| website: c.domain_name, | ||
| username: c.user_identifier, | ||
| password: c.password, | ||
| strength: computeStrength(c.password ?? ''), | ||
| lastUpdated: c.updated_at ?? c.created_at, | ||
| folderId: '', | ||
| tags: [], | ||
| })) | ||
| setCredentials(mapped) | ||
| } catch (err) { | ||
| console.error(err) | ||
| } finally { | ||
| setIsLoading(false) | ||
| } | ||
| } | ||
|
|
||
| fetchCredentials() | ||
| }, [userId]) | ||
|
|
||
| return { credentials, isLoading } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { useState, useEffect } from 'react' | ||
| import type { Folder } from '@/types/folder' | ||
|
|
||
| export function useFolders(userId: string) { | ||
| const [folders, setFolders] = useState<Folder[]>([]) | ||
| const [isLoading, setIsLoading] = useState(true) | ||
|
|
||
| useEffect(() => { | ||
| async function fetchFolders() { | ||
| try { | ||
| const url = new URL(`${process.env.NEXT_PUBLIC_API_URL}/folders`) | ||
| url.searchParams.append('user_id', userId) | ||
| const res = await fetch(url.toString(), { cache: 'no-store' }) | ||
| if (!res.ok) { | ||
| throw new Error('Erreur lors de la récupération des dossiers') | ||
| } | ||
| const data = await res.json() | ||
| const mapped = data.folders.map((f: any) => ({ | ||
| id: f.Id, | ||
| name: f.Name, | ||
| parentId: f.ParentID, | ||
|
There was a problem hiding this comment. Bug: Robustness gaps in Folder parent handling rails.The |
||
| })) | ||
| setFolders(mapped) | ||
| } catch (err) { | ||
| console.error(err) | ||
| } finally { | ||
| setIsLoading(false) | ||
| } | ||
| } | ||
|
|
||
| fetchFolders() | ||
| }, [userId]) | ||
|
|
||
| return { folders, isLoading } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { useState, useEffect } from 'react' | ||
| import type { Tag } from '@/types/tag' | ||
|
|
||
| export function useTags() { | ||
| const [tags, setTags] = useState<Tag[]>([]) | ||
| const [isLoading, setIsLoading] = useState(true) | ||
|
|
||
| useEffect(() => { | ||
| async function fetchTags() { | ||
| try { | ||
| const res = await fetch(`${process.env.NEXT_PUBLIC_API_URL}/tags`, { cache: 'no-store' }) | ||
| if (!res.ok) { | ||
| throw new Error('Erreur lors de la récupération des tags') | ||
| } | ||
| const data = await res.json() | ||
| const mapped = data.map((t: any) => ({ | ||
| id: t.id, | ||
| name: t.name, | ||
| color: t.color, | ||
| folderId: t.folder_id, | ||
| createdBy: t.created_by, | ||
| createdAt: t.created_at, | ||
| updatedAt: t.updated_at, | ||
| })) | ||
| setTags(mapped) | ||
| } catch (err) { | ||
| console.error(err) | ||
| } finally { | ||
| setIsLoading(false) | ||
| } | ||
| } | ||
|
|
||
| fetchTags() | ||
| }, []) | ||
|
|
||
| return { tags, isLoading } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export interface Folder { | ||
| id: string | ||
| name: string | ||
| parentId: string | null | ||
| shared?: boolean | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hardcoded defaults break filtering and types in credentials
The
useCredentialshook hardcodesfolderIdto an empty string andtagsto an empty array when mapping API responses. This breaks folder and tag filtering, as credentials won't match expected criteria. Additionally, potentiallynullAPI fields (e.g.,title,domain_name) are directly assigned to required string types inPasswordEntry, risking runtime errors.