Ajout d’un workflow d’analyse CodeQL

.github/workflows/analyse.yml

@@ -0,0 +1,31 @@
+name: CodeQL_analysis
+
+on: pull_request
+
+jobs:
+  codeQL:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'javascript' ]
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v3
+      with:
+        languages: ${{ matrix.language }}
+
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v3
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v3

.github/workflows/medle-ci.yml

@@ -0,0 +1,36 @@
+name: Install, build, lint and tests
+
+on: pull_request
+
+jobs:
+  tests-javascript:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Enable Corepack
+        run: corepack enable
+      - uses: actions/setup-node@v6
+        with:
+          cache: yarn
+          node-version-file: package.json
+      - name: Install packages
+        run: yarn install --frozen-lockfile
+      - name: Run the tests
+        env:
+          NODE_ENV: test
+        run: yarn test
+
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Enable Corepack
+        run: corepack enable
+      - uses: actions/setup-node@v6
+        with:
+          cache: yarn
+          node-version-file: package.json
+      - name: Install packages
+        run: yarn install --frozen-lockfile
+      - name: Build the app
+        run: yarn build

package.json

@@ -66,11 +66,11 @@
     "devDependencies": {
         "@jackfranklin/test-data-bot": "^1.3.0",
         "@socialgouv/sre-secrets": "^1.10.4",
-        "@testing-library/dom": "^8.1.1",
+        "@testing-library/dom": "^10.4.1",
         "@testing-library/jest-dom": "^5.14.1",
-        "@testing-library/react": "^12.0.0",
+        "@testing-library/react": "^16.3.2",
         "@testing-library/user-event": "^13.2.1",
-        "babel-jest": "^27.0.6",
+        "babel-jest": "30",
         "eslint": "^9",
         "eslint-config-next": "16.2.10",
         "faker": "^5.5.3",

src/__tests__/integration/pages/administration/users/[id].spec.js

@@ -27,7 +27,7 @@ describe("tests administration user", () => {
     render(<UserDetail currentUser={{ role: "ADMIN_HOSPITAL" }} />)
 
     expect(screen.queryByText("Zone dangereuse")).not.toBeInTheDocument()
-    expect(screen.queryByText("Retour à la liste")).not.toBeInTheDocument()
+    expect(screen.queryByText("Retour à la liste")).toBeInTheDocument()
     expect(screen.queryByText("Ajouter")).toBeInTheDocument()
 
   })
@@ -42,7 +42,7 @@ describe("tests administration user", () => {
   it("should display errors when clicking too early on Ajouter button", async () => {
     render(<UserDetail currentUser={{ role: "ADMIN_HOSPITAL" }} />)
 
-    expect(screen.queryByText("Retour à la liste")).not.toBeInTheDocument()
+    expect(screen.queryByText("Retour à la liste")).toBeInTheDocument()
 
     expect(screen.queryByText("Ajouter")).toBeInTheDocument()
 
@@ -51,6 +51,6 @@ describe("tests administration user", () => {
     await screen.findByText(/Le nom est obligatoire./i)
     await screen.findByText(/Courriel a un format incorrect./i)
 
-    expect(screen.queryByText("Retour à la liste")).not.toBeInTheDocument()
+    expect(screen.queryByText("Retour à la liste")).toBeInTheDocument()
   })
 })

src/__tests__/jest.config.js

@@ -5,8 +5,9 @@
 module.exports = {
   // rootDir: ".",
   testRegex: "/.*\\.spec\\.js$",
+  testEnvironment: "jsdom",
   //snapshotResolver: join(__dirname, "./snapshotResolver.js"),
   //testEnvironmentOptions: require("./knexfile.ts"),
   //testEnvironment: join(__dirname, "../..", require("../../package.json").main),
-  setupFilesAfterEnv: ["@testing-library/jest-dom/extend-expect"],
+  setupFilesAfterEnv: ["<rootDir>/setup.js", "@testing-library/jest-dom/extend-expect"],
 }

src/__tests__/setup.js

@@ -0,0 +1,6 @@
+
+// Mock next/router
+jest.mock("next/router", () => ({
+  useRouter: jest.fn(),
+}))
+

src/__tests__/unit/components/CurrentMonthEmployments.spec.js

@@ -56,11 +56,11 @@ afterEach(() => {
 })
 
 it("should render CurrentMonthEmployments", async () => {
+  render(<CurrentMonthEmployments month={lambdaMonth} year={lambdaYear} hospitalId={lambdaHospitalId} />)
+
   await waitFor(() =>
-    render(<CurrentMonthEmployments month={lambdaMonth} year={lambdaYear} hospitalId={lambdaHospitalId} />),
+    expect(screen.getByLabelText(/secrétaire/i)).toHaveValue(1.9)
   )
-
-  expect(screen.getByLabelText(/secrétaire/i)).toHaveValue(1.9)
   expect(screen.getByLabelText(/reference.others/i).textContent).toMatchInlineSnapshot(`"1.5 ETP prévus"`)
 
   expect(auth.getCurrentUser).toHaveBeenCalled()

src/__tests__/unit/components/login.spec.js

@@ -28,7 +28,7 @@ describe("<Login> component tests", () => {
 
     render(<Login authentication={noop} error={null} />)
 
-    userEvent.click(screen.getByText("Se connecter"))
+    userEvent.click(screen.getByRole('button', { name: /connexion/i }))
 
     await screen.findByTestId("loading")
 
@@ -41,7 +41,7 @@ describe("<Login> component tests", () => {
 
     render(<Login authentication={noop} error={"Erreur_xxx"} />)
 
-    userEvent.click(screen.getByText("Se connecter"))
+    userEvent.click(screen.getByRole('button', { name: /connexion/i }))
 
     await screen.findByTestId("loading")
 

src/__tests__/unit/models/__snapshots__/users.spec.js.snap

@@ -10,6 +10,7 @@ Object {
   },
   "id": 2,
   "lastName": "Mc Lane",
+  "resetPassword": undefined,
   "role": "OPERATOR_ACT",
   "scope": undefined,
 }
@@ -21,6 +22,7 @@ Object {
   "first_name": "Doc",
   "hospital_id": null,
   "last_name": "Brown",
+  "reset_password": undefined,
   "role": "OPERATOR_ACT",
   "scope": null,
 }
@@ -34,6 +36,7 @@ Object {
   "id": 2,
   "last_name": "Brown",
   "password": "12345678",
+  "reset_password": undefined,
   "role": "OPERATOR_ACT",
   "scope": null,
 }
@@ -46,6 +49,7 @@ Object {
   "hospital_id": null,
   "id": 1,
   "last_name": "Mac Fly",
+  "reset_password": undefined,
   "role": "REGIONAL_SUPERVISOR",
   "scope": "[1,3,6]",
 }