Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repairability to the inventory catalog #84

Closed
wants to merge 1 commit into from

Conversation

dchanman
Copy link

@dchanman dchanman commented Aug 2, 2022

The motivation for this is part of DMTF/Redfish-Use-Case-Checkers#62, where we'd like to create a usecase checker for assigning location-based identifiers for replaceable components in a system.

The motivation for that Usecase Checker is to help codify the Google repair identifier requirements documented in https://github.com/google/ecclesia-machine-management/blob/master/ecclesia/lib/redfish/g3doc/topology.md

Signed-off-by: Derek Chan [email protected]

@mraineri
Copy link
Contributor

mraineri commented Aug 5, 2022

Closing for the time being

@mraineri mraineri closed this Aug 5, 2022
Copy link
Author

@dchanman dchanman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future review: line 203 should be

if replaceable is not None:

because if Replaceable: False, we don't want it to check the LocationType field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants