Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/k1ch/Introduce Admin API - GET: roles/{key}/permissions #115

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

k1ch
Copy link
Collaborator

@k1ch k1ch commented Aug 14, 2024

Overview

Remaining items:

  • Unit test for both Database and Server packages
  • Remove PG Pool from database/layer/admin-rolepermission.js
OAS update:

image

Your PR Checklist 🚨

❤️ Please review the guidelines for contributing to this repository. Our goal is to merge PRs fast 💨 .

  • Check your code additions will fail neither code linting checks nor unit tests.
  • Additional units tests have been added to prove code updates work and fixes are effective
  • Additional documentation has been added (if appropriate)
  • Update Assignee field to yourself

Issue Reference

Relates to #106

Open Questions or Items to Callout

@k1ch k1ch self-assigned this Aug 14, 2024
@k1ch k1ch added the component: admin Administration related functionality label Aug 14, 2024
@k1ch k1ch marked this pull request as ready for review August 15, 2024 18:05
@k1ch k1ch requested a review from mikelax August 15, 2024 18:05
Copy link
Collaborator

@mikelax mikelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1ch this looks good, just one tiny change need for adding the 400 error code.

server/the-usher-openapi-spec.yaml Show resolved Hide resolved
@k1ch k1ch requested a review from mikelax August 15, 2024 20:53
@k1ch
Copy link
Collaborator Author

k1ch commented Aug 15, 2024

@mikelax Once this PR is merged, should we create a tag and release since this endpoint is needed for user360/authorizaion feature?

@k1ch
Copy link
Collaborator Author

k1ch commented Aug 15, 2024

@mikelax I have noticed that NODE-TESTS GitHub workflow fails sometimes. Have you experienced this before?

image

@mikelax
Copy link
Collaborator

mikelax commented Aug 15, 2024

NODE-TESTS GitHub workflow fails

@k1ch yes I think we should create a new release with this new API so we can take advantage of it.

@k1ch k1ch merged commit ae120dd into main Aug 15, 2024
2 checks passed
@k1ch k1ch deleted the topic/k1ch/admin-get-roles-permissions branch August 15, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Administration related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants