Add DWB path_follower critic #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l plan’s last pose when that pose has already been selected as the current intermediate goal.
…ad, make sure first robot only rotates in place to align with path
Avoid resetting path progress on timestamp-only plan updates
…-and-republish-global-plan Add global plan debug visualization
…logic-in-pathprogresscritic Fix PathProgressCritic final goal handling
…obal plan visualization as it is the one the critic receives
…-path_follower Add dedicated path follower critic
…sformed_global_plan Use transformed global plan orientation in path follower critic
…sm-in-pfc Remove snap goal mechanism from path follower critic
manual cleanup
Member
|
Hi Oscar, I didn't get around to testing this. I just noticed that the test is failing because it doesn't have a license header (see above). Is there a way to integrate |
Contributor
Author
Maybe, let me check. Otherwise I can make the necessary changes so that the pre-commit checks pass. |
Fix formatting per pre-commit feedback
Contributor
Author
|
Yeah, it was able! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Robot speed is reduced under current physics settings; enabling fast physics mitigates the problem
Tested in simulation; navigation through tight spaces shows improvement.
Final NOTE: Made almost entirely by OpenAI codex under my multiple and detailed instructions over several days.