Skip to content

Handle missing 'findBy' query param #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gunndabad wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Handle missing 'findBy' query param #3337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ingRecordSystem/src/TeachingRecordSystem.Api/V3/V20240101/Requests/FindTeachersRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindTeachersRequest

public enum FindTeachersFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/V20240606/Requests/FindPersonRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindPersonRequest

public enum FindPersonFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/V20240814/Requests/FindPersonRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindPersonRequest

public enum FindPersonFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/V20240920/Requests/FindPersonRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindPersonRequest

public enum FindPersonFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/V20250203/Requests/FindPersonRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindPersonRequest

public enum FindPersonFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/V20250327/Requests/FindPersonRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindPersonRequest

public enum FindPersonFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/V20250627/Requests/FindPersonRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ public record FindPersonRequest

public enum FindPersonFindBy
{
LastNameAndDateOfBirth = 1
LastNameAndDateOfBirth = 0
}
2 changes: 1 addition & 1 deletion ...dSystem/tests/TeachingRecordSystem.Api.IntegrationTests/V3/V20240101/FindTeachersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public async Task Get_ClientDoesNotHavePermission_ReturnsForbidden(string[] role
}

[Theory]
[InlineData("", "Invalid matching policy.")]
[InlineData("", "The value '' is invalid.")]
[InlineData("BadFindBy", "The value 'BadFindBy' is not valid for FindBy.")]
public async Task Get_InvalidFindBy_ReturnsError(string findBy, string expectedErrorMessage)
{
Expand Down
2 changes: 1 addition & 1 deletion ...RecordSystem.Api.IntegrationTests/V3/V20240606/FindPersonByLastNameAndDateOfBirthTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public async Task Get_ClientDoesNotHavePermission_ReturnsForbidden(string[] role
}

[Theory]
[InlineData("", "Invalid matching policy.")]
[InlineData("", "The value '' is invalid.")]
[InlineData("BadFindBy", "The value 'BadFindBy' is not valid for FindBy.")]
public async Task Get_InvalidFindBy_ReturnsError(string findBy, string expectedErrorMessage)
{
Expand Down
Loading