Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pytest example README typo #491

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Fixes pytest example README typo #491

merged 1 commit into from
Dec 30, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Dec 30, 2024

Fixing typo.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Fixes typo in examples/pytest/README.md by rephrasing a sentence for clarity.

  • Documentation:
    • Fixes typo in examples/pytest/README.md by rephrasing a sentence for clarity regarding capturing code versions with datasets.

This description was created by Ellipsis for 80f2eba. It will automatically update as commits are pushed.

@skrawcz skrawcz merged commit f7125d2 into main Dec 30, 2024
6 checks passed
@skrawcz skrawcz deleted the fix_pytest_typo branch December 30, 2024 06:57
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 80f2eba in 6 seconds

More details
  • Looked at 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. examples/pytest/README.md:356
  • Draft comment:
    Typo fix: Change 'to' to 'with' for clarity.
one needs to tie together the version of the code that generated the data set with the data set itself.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR fixes a typo in the README file. The change is appropriate and improves clarity.

Workflow ID: wflow_VscVojiFEaKRp7Qu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 30, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/491

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/491/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant