Adds support for IsExecuting to Reactive Commands #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new overloads of `SubscribeAwait` to accept a state parameter - Updated existing async operators to handle state
- Introduced `IsExecuting` property to track command execution state. - Added `executionCount` field for managing concurrent executions. - Updated synchronous and asynchronous execution methods to handle the new execution logic. - Ensured proper disposal of resources related to command execution.
- Introduced a new overload for SelectAwait that includes a state parameter. - Added multiple classes to handle different AwaitOperation types with the new TState feature. - Implemented error handling and completion logic in the new classes. - Enhanced concurrency control with maxConcurrent option for parallel operations.
- Added support for being notified when IsExecuting has been changed
- Updated subscription logic for command execution. - Improved async handling in subscription methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactiveProperty<bool> IsExecutingtoReactiveCommandimplementations. This is helpful to know when theexecuteorconvertlogic portion of a command is running.I originally implemented the execution count modification using
Interlockedmethods and then updating theIsExecutingproperty, but it seemed like it would be less error-prone to just update the counts and theIsExecutingin a singular lock statement.statevariables toSelectAwaitandSubscribeAwait.HandleAsyncExecutionmethods in a closure.