CSI 1537 Changelly Integration - #376
Draft
arnabCypherock wants to merge 16 commits into
Draft
Conversation
Integrated the API calls for the Swap Token functionality
Added a new method that downloads a JS object as a CSV file. It is used to download the swap transactions that took place.
In the Swap History panel, a drop down will list all the wallet that are available and selecting them will list only the transactions in that wallet
…on-flow-hooks_Arnab-Sen
irshadCypherock
requested changes
Feb 14, 2023
| RECEIVE_TXN_CANCEL_FAILED = 'DS_OPTS_1507', | ||
| RECEIVE_TXN_UNKNOWN_ERROR = 'DS_MISC_5502', | ||
|
|
||
| SWAP_TXN_UNKNOWN_ERROR = 'TODO_1234', // TODO: add error code |
Author
There was a problem hiding this comment.
Can you suggest me the code? Is there any format that we follow? What does the number at the end signify?
Comment on lines
+188
to
+191
| { | ||
| tab: 10, // this is a dummy value for the Swap tab | ||
| route: Routes.swap.index //TODO: Update the route | ||
| }, |
Collaborator
There was a problem hiding this comment.
Add it at the 2nd last index of array and remove comments
Collaborator
There was a problem hiding this comment.
Also update the values of tab index
Author
There was a problem hiding this comment.
The values of just this particular tab or the rest of the tabs as well?
Comment on lines
+20
to
+21
| id={`simple-tabpanel-${index}`} | ||
| aria-labelledby={`simple-tab-${index}`} |
Collaborator
There was a problem hiding this comment.
Replace generic name for ID and label by actual name
Comment on lines
+60
to
+69
| style={{ | ||
| width: '80%', | ||
| height: '88%', | ||
| position: 'absolute', | ||
| flexDirection: 'column', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| zIndex: 100, | ||
| display: 'flex' | ||
| }} |
| @@ -0,0 +1,161 @@ | |||
| import { CallReceived, ContentCopy } from '@mui/icons-material'; | |||
Collaborator
There was a problem hiding this comment.
I don't think we need a panels folder. It can just be swap/dialog swap/exchange etc
| ); | ||
| }; | ||
|
|
||
| export default function received() { |
Collaborator
There was a problem hiding this comment.
Use Pascal Case for Component naming
Comment on lines
+84
to
+104
| { | ||
| <SwapDetailsForm | ||
| fromToken={fromToken} | ||
| setFromToken={setFromToken} | ||
| toToken={toToken} | ||
| setToToken={setToToken} | ||
| amountToSend={amountToSend} | ||
| setAmountToSend={setAmountToSend} | ||
| handleChangeAmountToSend={handleChangeAmountToSend} | ||
| classesForm={classes.form} | ||
| allWallets={allWallets} | ||
| amountToReceive={amountToReceive || '0'} | ||
| price={toToken?.price || 0} | ||
| toWallet={toWallet} | ||
| setToWallet={setToWallet} | ||
| fromWallet={fromWallet} | ||
| fromWalletCoinData={fromWalletCoinData} | ||
| toWalletCoinData={toWalletCoinData} | ||
| setFromWallet={setFromWallet} | ||
| /> | ||
| } |
Comment on lines
+143
to
+171
| {showSwapDetailsVerifyDialog && ( | ||
| <VerifySwapDetailsDialog | ||
| open={showSwapDetailsVerifyDialog} | ||
| onClose={() => { | ||
| cancelSwapTransaction(); | ||
| setShowSwapDetailsVerifyDialog(false); | ||
| }} | ||
| amountToSend={amountToSend} | ||
| amountToReceive={amountToReceive} | ||
| networkFees={fees} | ||
| sourceCoinSlug={COINS[fromToken.coinId].abbr.toUpperCase()} | ||
| sourceCoinName={fromToken.coinId} | ||
| targetCoinSlug={COINS[toToken.coinId].abbr.toUpperCase()} | ||
| targetCoinName={toToken.coinId} | ||
| receiveAddress={receiveAddress} | ||
| receiveFlowStep={receiveFlowStep} | ||
| sendFlowStep={sendFlowStep} | ||
| /> | ||
| )} | ||
| {showSwapCompletedDialog && ( | ||
| <SwapCompletedDialog | ||
| open={showSwapCompletedDialog} | ||
| onClose={() => { | ||
| setSwapCompletedDialog(false); | ||
| }} | ||
| toTokenName={COINS[toToken.coinId]?.name} | ||
| transactionId={swapTransaction.changellyTxnId} | ||
| /> | ||
| )} |
Collaborator
There was a problem hiding this comment.
We don't need conditional rendering when we are passing the open prop
| @@ -0,0 +1,817 @@ | |||
| import { | |||
Collaborator
There was a problem hiding this comment.
This file it too large, try splitting it into different files
Collaborator
|
Task linked: CU-85zrh0zen Build swap transaction flow hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.