Bump Feat: Csi 1413 create UI for exchange - #328
Draft
irshadCypherock wants to merge 9 commits into
Draft
Conversation
Integrated the API calls for the Swap Token functionality
Added a new method that downloads a JS object as a CSV file. It is used to download the swap transactions that took place.
In the Swap History panel, a drop down will list all the wallet that are available and selecting them will list only the transactions in that wallet
irshadCypherock
commented
Nov 21, 2022
Comment on lines
+170
to
+172
| const { data } = await axios.get(`${baseUrl}/exchangeDetails`, { | ||
| params: { from: fromToken.slug, to: toToken.slug, amount: amountToSend } | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
Error handling missing
Comment on lines
+186
to
+194
| const { data } = await axios.get(`${baseUrl}/transaction`, { | ||
| params: { | ||
| walletId, | ||
| from: fromToken.slug, | ||
| to: toToken.slug, | ||
| amount: amountToSend, | ||
| address: receiveAddress | ||
| } | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
Error handling missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.