feat: added storybook ui components - #434
Open
Ishaan28malik wants to merge 7 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 10b7e3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
irshadCypherock
requested changes
Apr 20, 2024
Comment on lines
+36
to
+47
| lock: () => { | ||
| console.log('Lock action'); | ||
| }, | ||
| toggleDiscreetMode: () => { | ||
| console.log('Toggling discreet mode'); | ||
| }, | ||
| onNotificationClick: () => { | ||
| console.log('Notification clicked'); | ||
| }, | ||
| onSyncClick: () => { | ||
| console.log('Sync clicked'); | ||
| }, |
Collaborator
There was a problem hiding this comment.
UI does not look good.
Contributor
Author
There was a problem hiding this comment.
This wasn't done from my end @irshadCypherock
Comment on lines
+14
to
+21
| export const Default: Story = { | ||
| args: { | ||
| overrideDecimal: undefined, | ||
| error: undefined, | ||
| value: 2, | ||
| captions: [], | ||
| }, | ||
| }; |
Collaborator
There was a problem hiding this comment.
Slider does not work
Comment on lines
+14
to
+16
| export const Default: Story = { | ||
| args: {}, | ||
| }; |
Collaborator
There was a problem hiding this comment.
Pass required props
Comment on lines
+14
to
+19
| export const Default: Story = { | ||
| args: { | ||
| text: 'Placeholder', | ||
| value: true, | ||
| }, | ||
| }; |
Collaborator
There was a problem hiding this comment.
Pass required props
irshadjsr21
requested changes
May 6, 2024
Comment on lines
+14
to
+20
| export const Default: Story = { | ||
| args: { | ||
| margin: undefined, | ||
| leftComponent: undefined, | ||
| rightComponent: undefined, | ||
| }, | ||
| }; |
Collaborator
There was a problem hiding this comment.
This displays empty component
Contributor
Author
There was a problem hiding this comment.
Now it is appearing
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| value: '10', |
Collaborator
There was a problem hiding this comment.
Missing argument: postfixText
Comment on lines
+13
to
+21
| let address = 'Noida, Delhi'; | ||
| export const Default: Story = { | ||
| args: { | ||
| value: address, | ||
| onChange: newAddress => { | ||
| address = newAddress; | ||
| }, | ||
| }, | ||
| }; |
Comment on lines
+13
to
+22
| let toggleValue = true; | ||
| export const Default: Story = { | ||
| args: { | ||
| text: 'Placeholder', | ||
| value: toggleValue, | ||
| onChange: newToggleValue => { | ||
| toggleValue = newToggleValue; | ||
| }, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI storybook added for missing and new components