fix(indexer): disambiguate dual-shape parsing by arity and enum-tag heuristic (#170) - #179
Open
trenysx wants to merge 1 commit into
Open
fix(indexer): disambiguate dual-shape parsing by arity and enum-tag heuristic (#170)#179trenysx wants to merge 1 commit into
trenysx wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #170
Problem: The parseCampaignRegistered and parseFarmerRegistered parsers used a fragile ypeof === 'string' check to distinguish between the direct-call payload (which includes a real title/name) and the activity-log mirror payload (which emits an ActivityAction enum tag in the same slot). The stellar-sdk can decode fieldless enums as a bare string, a single-element array (['Variant']), or a { tag: 'Variant' } object. A bare-string enum decode would pass the ypeof === 'string' check and corrupt the campaign title/farmer name with the enum variant name (e.g., "CampaignRegistered").
Solution: Disambiguate deterministically by payload structure:
Added looksLikeEnumTag helper for bare-string enum detection.
Tests added (regression coverage for all three documented enum-decoding shapes):
All 51 unit tests pass; sc --noEmit and eslint clean.