fix(indexer): wrap event handlers in Prisma transaction to prevent poison-pill events (#168) - #178
Open
trenysx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #168
Problem: Event handlers in persistEvent perform multiple separate prisma.* calls without a transaction wrapper. If a handler fails mid-way (e.g., investment.create succeeds but campaign.update throws), the partial writes remain committed while the idempotency-marking Transaction row is never written. On the next poll, the event is reprocessed but immediately fails on the unique constraint of the already-existing partial row — a permanent "poison pill" that spams error logs forever.
Solution: Wrap each handler's writes + the final Transaction row insert in a single prisma.(async (tx) => { ... }) so a partial failure rolls back cleanly and the event can be retried from a consistent state.
Changes in server/src/indexer/parsers/event-parser.service.ts:
Tests added in event-parser.service.spec.ts:
All 47 unit tests pass; sc --noEmit and eslint are clean.