-
Notifications
You must be signed in to change notification settings - Fork 42
Include library folder in Python packages
#184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
7146657
2f930bb
25955d9
56512eb
42b7a5e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| include README.md LICENSE requirements.txt main.py | ||
| recursive-include src/library *.yml | ||
| recursive-include tests *.py | ||
| recursive-include src * | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,11 +9,10 @@ RUN mkdir -p /raven/tests | |
| WORKDIR /raven | ||
| COPY Makefile requirements.txt /raven/ | ||
| COPY src /raven/src | ||
| COPY library /raven/library | ||
| COPY tests /raven/tests | ||
|
|
||
| # Install any needed packages specified in requirements.txt | ||
| RUN pip3 install -r requirements.txt | ||
|
|
||
| # Run RAVEN tests | ||
| CMD ["make", "test-run"] | ||
| CMD ["make", "test-run"] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove extra line added |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,4 +45,5 @@ | |
| install_requires=REQUIRMENTS, | ||
| packages=find_packages(exclude=("tests", "tests.*")), | ||
| entry_points={"console_scripts": ["raven = src.cmdline:execute"]}, | ||
| include_package_data=True, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this required? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a safeguard, it looks like it's at |
||
| ) | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to
library *.ymlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the whole point of this PR, right now you are not including the library within the Python package, and the culprit is that the library it outside the package source, you could maybe do a build hook with setuptools but that is way more complicated than just moving it into the source tree.
See below the build log, the
ymlfiles are never included: