Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VulnerabilityAnalysis properties for issued/updated datetime #794

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

indiVar0508
Copy link
Contributor

fixed: #791

add first_issued and last_updated to VulnerabilityAnalysis, update test to verify this

@indiVar0508 indiVar0508 requested a review from a team as a code owner February 27, 2025 16:28
@jkowalleck jkowalleck added the enhancement New feature or request label Feb 27, 2025
Copy link
Member

@jkowalleck jkowalleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost perfect.

a thing that is needed since the latest v9 release:

  • please add the new properties to the __comparable_tuple()

add first_issued and last_updated to VulnerabilityAnalysis,
update test to verify this

Signed-off-by: Indivar Mishra <[email protected]>
@indiVar0508
Copy link
Contributor Author

ahh so close, I felt i was missing something 😄
test results logs

Files skipped (0):
  flake8: OK (2.55=setup[0.04]+cmd[0.00,0.92,0.57,1.01] seconds)
  mypy-current: OK (2.25=setup[0.01]+cmd[0.00,0.86,0.53,0.84] seconds)
  mypy-lowest: OK (1.93=setup[0.01]+cmd[0.00,0.61,0.53,0.78] seconds)
  py313-allExtras: SKIP (0.14 seconds)
  py313-noExtras: SKIP (0.36 seconds)
  py312-allExtras: SKIP (0.15 seconds)
  py312-noExtras: SKIP (0.14 seconds)
  py311-allExtras: SKIP (0.20 seconds)
  py311-noExtras: SKIP (0.11 seconds)
  py310-allExtras: OK (8.14=setup[0.02]+cmd[0.00,0.60,0.51,7.00] seconds)
  py310-noExtras: OK (6.82=setup[0.01]+cmd[0.00,0.58,0.51,5.71] seconds)
  py39-allExtras: SKIP (0.10 seconds)
  py39-noExtras: SKIP (0.09 seconds)
  py38-allExtras: SKIP (0.09 seconds)
  py38-noExtras: SKIP (0.11 seconds)
  bandit: OK (2.63=setup[0.01]+cmd[0.00,0.80,0.51,1.31] seconds)
  congratulations :) (25.86 seconds)

@jkowalleck jkowalleck merged commit 4a3955a into CycloneDX:main Feb 27, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: VulnerabilityAnalysis properties for issued/updated datetime
2 participants