feat: add CPE format validation in property setter #706
Conversation
- Implemented regex-based validation for CPE format in the model. - Added tests to verify handling of invalid CPE strings. Signed-off-by: Saquib Saifee <[email protected]>
|
@madpah and @jkowalleck please advise if these changes are enough to add this validation. |
Signed-off-by: Saquib Saifee <[email protected]>
| @@ -1457,6 +1467,8 @@ def cpe(self) -> Optional[str]: | |||
|
|
|||
| @cpe.setter | |||
| def cpe(self, cpe: Optional[str]) -> None: | |||
| if cpe and not CPE_REGEX.fullmatch(cpe): | |||
| raise ValueError(f'Invalid CPE format: {cpe}') | |||
There was a problem hiding this comment.
This behavioral change is a breaking change.
This is a remark, not a blocker. :-)
There was a problem hiding this comment.
CPE is a complex, external spec - outside the domain of CycloneDX.
This fact leads me to the architectural decision: we do not want to maintain an implementation of this external spec in the domain of CycloneDX python library.
meaning: this PR will not be accepted in its current form.
we might consider a usage of an external library, like https://pypi.org/project/cpe/.
jkowalleck
changed the title
|
Thank you for the PR, @saquibsaifee . I will close this PR for reasons detailed in #706 (review) For a different approach, please open a new pullrequest. |
Fixes #580