Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add acknowledgement to LicenseExpression #582

Conversation

madpah
Copy link
Collaborator

@madpah madpah commented Apr 8, 2024

No description provided.

@madpah madpah added the enhancement New feature or request label Apr 8, 2024
@madpah madpah self-assigned this Apr 8, 2024
@madpah madpah changed the base branch from main to feat/support-cyclonedx-1.6 April 8, 2024 12:13
@madpah madpah marked this pull request as ready for review April 8, 2024 12:13
@madpah madpah requested a review from a team as a code owner April 8, 2024 12:13
@madpah madpah mentioned this pull request Apr 8, 2024
4 tasks
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.75% 90.27% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (35749c6) 3424 3204 93.57%
Head commit (eb5f2cf) 4435 (+1011) 4117 (+913) 92.83% (-0.75%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#582) 1131 1021 90.27%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5c97c2d) 4419 4101 92.80%
Head commit (eb5f2cf) 4435 (+16) 4117 (+16) 92.83% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#582) 19 19 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@madpah madpah merged commit ddd7847 into feat/support-cyclonedx-1.6 Apr 8, 2024
44 checks passed
@madpah madpah deleted the feat/add-acknowledgement-to-license-expression branch April 8, 2024 12:16
madpah added a commit that referenced this pull request Apr 9, 2024
* added draft v1.6 schemas and boilerplate for v1.6

Signed-off-by: Paul Horton <[email protected]>

* re-generated test snapshots for v1.6

Signed-off-by: Paul Horton <[email protected]>

* note `bom.metadata.manufacture` as deprecated

Signed-off-by: Paul Horton <[email protected]>

* work on `bom.metadata` for v1.6

Signed-off-by: Paul Horton <[email protected]>

* Deprecated `.component.author`. Added `.component.authors` and `.component.manufacturer`

Signed-off-by: Paul Horton <[email protected]>

* work to add `.component.omniborid` - but tests deserialisation tests fail due to schema differences (`.component.author` not in 1.6)

Signed-off-by: Paul Horton <[email protected]>

* work to get deserialization tests passing

Signed-off-by: Paul Horton <[email protected]>

* chore(deps): bump `py-serializable` to >=1.0.3 to resolve issues with deserialization to XML

Signed-off-by: Paul Horton <[email protected]>

* imports tidied

Signed-off-by: Paul Horton <[email protected]>

* properly added `.component.swhid`

Signed-off-by: Paul Horton <[email protected]>

* add `.component.cryptoProperties` - with test failures for SchemaVersion < 1.6

Signed-off-by: Paul Horton <[email protected]>

* typing and bandit ignores

Signed-off-by: Paul Horton <[email protected]>

* coding standards

Signed-off-by: Paul Horton <[email protected]>

* test filtering

Signed-off-by: Paul Horton <[email protected]>

* coding standards

Signed-off-by: Paul Horton <[email protected]>

* additional tests to increase code coverage

Signed-off-by: Paul Horton <[email protected]>

* corrected CryptoMode enum

Signed-off-by: Paul Horton <[email protected]>

* coding standards

Signed-off-by: Paul Horton <[email protected]>

* Added `address` to `organizationalEntity`

Signed-off-by: Paul Horton <[email protected]>

* Added `address` to `organizationalEntity`

Signed-off-by: Paul Horton <[email protected]>

* raise `UserWarning` in `.component.version` has length > 1024

Signed-off-by: Paul Horton <[email protected]>

* coding standards and typing

Signed-off-by: Paul Horton <[email protected]>

* add `acknowledgement` to `LicenseExpression` (#582)


Signed-off-by: Paul Horton <[email protected]>

* more proper way to filter test cases

Signed-off-by: Paul Horton <[email protected]>

* update schema to published versions

Signed-off-by: Paul Horton <[email protected]>

* fetch schema 1.6 JSON

Signed-off-by: Jan Kowalleck <[email protected]>

* fetch test data for CDX 1.6

Signed-off-by: Jan Kowalleck <[email protected]>

* reformat

Signed-off-by: Jan Kowalleck <[email protected]>

* reformat

Signed-off-by: Jan Kowalleck <[email protected]>

* refactor

Signed-off-by: Jan Kowalleck <[email protected]>

* style

Signed-off-by: Jan Kowalleck <[email protected]>

* refactor

Signed-off-by: Jan Kowalleck <[email protected]>

* docs

Signed-off-by: Jan Kowalleck <[email protected]>

---------

Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Co-authored-by: Jan Kowalleck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request schema 1.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant