-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE 2.0.0 #148
Merged
Merged
RELEASE 2.0.0 #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP but a lil hand up for @madpah Signed-off-by: Jeffry Hesse <[email protected]> * chore: added missing license header Signed-off-by: Paul Horton <[email protected]> * No default values for required fields * Add Services to BOM * Typo fix * aligned classes with standards, commented out Signature work for now, added first tests for Services Signed-off-by: Paul Horton <[email protected]> * addressed standards Signed-off-by: Paul Horton <[email protected]> * 1.2.0 Automatically generated by python-semantic-release Signed-off-by: Paul Horton <[email protected]> * feat: `bom-ref` for Component and Vulnerability default to a UUID (#142) * feat: `bom-ref` for Component and Vulnerability default to a UUID if not supplied ensuring they have a unique value #141 Signed-off-by: Paul Horton <[email protected]> * doc: updated documentation to reflect change Signed-off-by: Paul Horton <[email protected]> * patched other tests to support UUID for bom-ref Signed-off-by: Paul Horton <[email protected]> * better syntax Signed-off-by: Paul Horton <[email protected]> * 1.3.0 Automatically generated by python-semantic-release Signed-off-by: Paul Horton <[email protected]> * WIP but a lil hand up for @madpah Signed-off-by: Jeffry Hesse <[email protected]> Signed-off-by: Paul Horton <[email protected]> * chore: added missing license header Signed-off-by: Paul Horton <[email protected]> * aligned classes with standards, commented out Signature work for now, added first tests for Services Signed-off-by: Paul Horton <[email protected]> * removed signature from this branch Signed-off-by: Paul Horton <[email protected]> * Add Services to BOM * Typo fix * addressed standards Signed-off-by: Paul Horton <[email protected]> * resolved typing issues from merge Signed-off-by: Paul Horton <[email protected]> * added a bunch more tests for JSON output Signed-off-by: Paul Horton <[email protected]> Co-authored-by: Paul Horton <[email protected]> Co-authored-by: github-actions <[email protected]>
…#152 Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
…BOM output in XML #150 Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
@madpah let me know if you need a second opinion or a code review |
feat: support nested services in JSON and XML BOMs Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
* fix: implemented correct `__hash__` methods in models (#153) Signed-off-by: Paul Horton <[email protected]>
This was
linked to
issues
Feb 2, 2022
Closed
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
…this library supports Signed-off-by: Paul Horton <[email protected]>
jkowalleck
previously requested changes
Feb 2, 2022
…ted out by @jkowalleck Signed-off-by: Paul Horton <[email protected]>
This was
linked to
issues
Feb 3, 2022
* BREAKING CHANGE: update models to use `Set` and `Iterable` rather than `List[..]` BREAKING CHANGE: update final models to use `@property` wip Signed-off-by: Paul Horton <[email protected]>
* feat: support complete model for `bom.metadata` fix: JSON comparison in unit tests was broken chore: corrected some source license headers Signed-off-by: Paul Horton <[email protected]>
All resolved, but review not closing?
Signed-off-by: Paul Horton <[email protected]>
This was
linked to
issues
Feb 8, 2022
…(in the schema it is) - we generate a UUID if `bom_ref` is not supplied explicitly Signed-off-by: Paul Horton <[email protected]>
jkowalleck
reviewed
Feb 16, 2022
…st supported #171 (#173) Signed-off-by: Paul Horton <[email protected]>
…sure uniquness and dependency references (#174) Signed-off-by: Paul Horton <[email protected]>
…175) * BREAKING CHANGE: added new model `BomRef` unlocking logic later to ensure uniquness and dependency references Signed-off-by: Paul Horton <[email protected]> * updated Vulnerability to also use new `BomRef` model Signed-off-by: Paul Horton <[email protected]>
jkowalleck
previously requested changes
Feb 19, 2022
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
BREAKING CHANGE: Adopt PEP-3102 BREAKING CHANGE: Optional Lists are now non-optional Sets BREAKING CHANGE: Remove concept of DEFAULT schema version - replaced with LATEST schema version BREAKING CHANGE: Added `BomRef` data type Signed-off-by: Paul Horton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lil hand up for @madpah , just sort of the way towards having Services implemented (but not all the way there).
This PR will contain a number of additional features:
bom.services
) #123bom.components
#155bom.externalReferences
) #124bom.metadata
#61.4
#163components
is still present in the generated BOM #147Component.bom_ref
/Service.bom_ref
#170Bugs squashed:
component.licenses
not valid against schema in version 1.0 #151__hash__
implementation inComponent
attempts to hash unhashable properties list if present #153License()
parameterspxd_license_id
- should bespdx_license_id
#176License
does not serializelicense_url
to the output. #179This WIP PR is being squashed into a new feature branch where work will continue.
Note: Work originally squashed from #145.
supersedes #154