Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] no default schema #171

Closed
jkowalleck opened this issue Feb 16, 2022 · 1 comment · Fixed by #173
Closed

[BREAKING] no default schema #171

jkowalleck opened this issue Feb 16, 2022 · 1 comment · Fixed by #173
Assignees
@madpah
Labels
breaking change
Milestone
2.0.0

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Feb 16, 2022 •
edited
Loading

caused by #163 / #164

proposal / expected outcome

  • do not use a default schema at all
  • rename DEFAULT_SCHEMA_VERSION to LATEST_SUPPORTED_SCHEMA_VERSION
  • there is no defaulting or magic when it comes to SchemaVersions. Users have to input a valid value..

motivation:

  • no more breaking changes, when a new schema version is added. they are just features the users can plug.
@madpah madpah self-assigned this Feb 16, 2022
@madpah madpah added this to the 2.0.0 milestone Feb 16, 2022
madpah added a commit that referenced this issue Feb 16, 2022
@madpah
BREAKING CHANGE: replaced concept of default schema version with late…
2f2b21e 
…st supported #171

Signed-off-by: Paul Horton <[email protected]>
@madpah madpah mentioned this issue Feb 16, 2022
Merged
@madpah madpah linked a pull request Feb 16, 2022 that will close this issue
BREAKING CHANGE: replaced concept of default schema version with latest supported #171 #173
Merged
madpah added a commit that referenced this issue Feb 16, 2022
@madpah
BREAKING CHANGE: replaced concept of default schema version with late…
020fcf0 
…st supported #171 (#173)

Signed-off-by: Paul Horton <[email protected]>
@madpah
Copy link
Collaborator

madpah commented Feb 21, 2022

https://pypi.org/project/cyclonedx-python-lib/2.0.0/ released

@madpah madpah closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madpah madpah

Labels
breaking change
Projects
None yet
Milestone
2.0.0
2 participants
@jkowalleck @madpah