Skip to content

Conversation

VishalRohra
Copy link
Contributor

@VishalRohra VishalRohra commented Jan 6, 2017

Added the python section. Not sure why it wasn't already there.

@CuriousLearner
Copy link
Owner

Your second commit is same as what @sahilshekhawat has done in #4 . This is nice but it isn't working correctly for all links as I mentioned in the PR. Also for the PDF the anchor isn't working correctly. It would be great if you inspect the issue.

Else, we can go ahead adding just the Python category to the scrapper.

@CuriousLearner
Copy link
Owner

Let me know what you think about this @VishalRohra

@VishalRohra
Copy link
Contributor Author

Sorry, messed up on branching. Not sure how to fix it for all links. Please go ahead with the first commit.

@CuriousLearner
Copy link
Owner

@VishalRohra Just hard reset to first commit via
git reset --hard d991bdc

Then do force push to your branch
git push <remote-name> <branch-name> -f

It's okay to make mistakes, what is really essential is that you learn from them :)
Please do the changes, and I'll merge them. Thanks for your contributions.

@CuriousLearner CuriousLearner self-assigned this Mar 16, 2017
@CuriousLearner
Copy link
Owner

This looks good to me! I'm squashing and merging the commit. I hope you've learned some git. If you need any help, please feel free to ping me.

Thanks for your contributions.

@CuriousLearner CuriousLearner merged commit aa9216d into CuriousLearner:master Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants