Replace GitHub secrets with variables in release workflow - #261
Merged
Conversation
Replace secrets.WORKLOAD_IDENTITY_PROVIDER, secrets.SERVICE_ACCOUNT, and secrets.SERVICE_ANNOTATION with repository variables (vars.*), and inline the gcr.io login username as the well-known oauth2accesstoken value. None of these are secret: the WIF provider path and service account email are keyless-auth identifiers, the annotation is OCI image metadata, and oauth2accesstoken is the canonical username used with a short-lived GCP access token. Also switch the release trigger from types:[created] to types:[published] so releases published from a draft fire the workflow.
redhatrises
approved these changes
Jul 8, 2026
evanstoner
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow previously authenticated to Google Cloud and configured image publishing using GitHub secrets. Since we can no longer use GitHub secrets, this migrates those values to GitHub repository variables.
All of the values involved are non-sensitive public identifiers — the workload identity provider path, the service account email, image registry and names, and the marketplace service annotation — so they are safe to store as plaintext variables. Authentication to GCP continues to use Workload Identity Federation over the GitHub OIDC token, which mints a short-lived access token at runtime, so no long-lived credentials are stored anywhere. The gcr.io docker login now uses the fixed
oauth2accesstokenusername with that runtime token instead of a stored registry login secret.The container and deployer jobs are unchanged in behavior; only their input sources moved from
secrets.*tovars.*.