Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PHP 8.4 #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Upgrade to PHP 8.4 #60

wants to merge 5 commits into from

Conversation

marvindurot
Copy link

@marvindurot marvindurot commented Mar 6, 2025 •
edited
Loading

This pull request contains changes for upgrading to PHP 8.4 automated by Rector.

Before merging, you need to:

  • Checkout the shift-142737 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, try with --no-scripts)
  • Run your tests suite: vendor/bin/phpunit

To update Composer dependencies with Docker :

docker run --rm --interactive --tty --volume $PWD:/app --user $(id -u):$(id -g) composer install

To run the tests with Docker :

docker run -it --rm --name my-running-script --user $(id -u):$(id -g) \
-v "$PWD":/usr/src/myapp -w /usr/src/myapp php:8.4-cli \
vendor/bin/phpunit tests

Marvin Durot and others added 5 commits March 6, 2025 17:22
Upgrade to PHP 8.4 with Rector
627f49d
@laravel-shift
Bump PHPUnit dependencies
4ffb145
@laravel-shift
Set return type of base TestCase methods
61112af 
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type:

- `setUpBeforeClass()`
- `setUp()`
- `assertPreConditions()`
- `assertPostConditions()`
- `tearDown()`
- `tearDownAfterClass()`
- `onNotSuccessfulTest()`

[1]: https://phpunit.de/announcements/phpunit-8.html
@laravel-shift
Ignore PHPUnit cache folder
4689f70
@laravel-shift
Define test classes as final
d982c85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvindurot @laravel-shift