perf: memoize the heavy transformer in the transactions table - #1037
Open
waterWang wants to merge 1 commit into
Open
perf: memoize the heavy transformer in the transactions table#1037waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Pre-compute formatted display values (amount, relative time, status badge variant, truncated hash) in a useMemo so that expensive operations such as toLocaleString, Date arithmetic, and i18n lookups run only when the source data or filter changes, not on every render. Closes CredenceOrg#948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #948
Summary
Pre-computes formatted display values (amount, relative time, status badge variant, truncated hash) in a
useMemoso that expensive operations such astoLocaleString, Date arithmetic, and i18n lookups run only when the source data or filter changes, not on every render.Changes
TableRowinterface extendingTransactionwith pre-computed display fieldsuseMemothat transformsfiltereddata intotableRowswith pre-formatted valuestableRowsinstead offilteredand read pre-computed values