refactor: extract theme-detector into useThemeDetector hook (Closes #950) - #1031
Open
waterWang wants to merge 1 commit into
Open
refactor: extract theme-detector into useThemeDetector hook (Closes #950)#1031waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Move the theme-application logic (data-theme sync, matchMedia listener
management for system mode) from SettingsContext's inline useEffect
into a dedicated useThemeDetector hook under src/hooks/.
The hook accepts a ThemeMode ('light' | 'dark' | 'system') and handles:
- Resolving the effective theme (querying prefers-color-scheme in system mode)
- Writing data-theme on document.documentElement
- Subscribing to OS preference changes when mode is 'system'
- Cleaning up the listener on mode switch or unmount
Behavior is identical — the change is a no-op refactor.
Closes CredenceOrg#950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the theme-application logic from
SettingsContext's inlineuseEffectinto a dedicateduseThemeDetectorhook undersrc/hooks/.Changes
src/hooks/useThemeDetector.ts— A hook that accepts aThemeMode('light'|'dark'|'system') and:prefers-color-schemein system mode)data-themeondocument.documentElement'system'src/context/SettingsContext.tsx— Replaced inlineuseEffectwithuseThemeDetector(themeMode)Verification
SettingsContext.theme.test.tsxpassCloses #950