fix: amount precision and overflow in admin pause signer counting - #1303
Merged
Baskarayelu merged 1 commit intoAug 29, 2026
Merged
Conversation
|
@Devadakene Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1294
Description
This PR makes privileged configuration, pause, ownership, and dispute operations bounded, time-aware, and safely recoverable.
Specifically, it replaces
saturating_addandsaturating_subincontracts/admin/src/pausable.rs(when modifyingPauseSignerCount) withchecked_addandchecked_sub. Instead of silently saturating values, the contract now immediately reverts and throws aContractError::Overflowpanic. This explicitly rejects invalid scale, sign, and overflow cases before any state changes are persisted, providing a deterministic and reviewable guarantee under normal, concurrent, and failure conditions.Closes #(issue-number)
Type of Change
How Has This Been Tested?
cargo test --workspacepassescargo fmt --all -- --checkpassescargo clippy --workspace --all-targets --all-features -- -D warningspassescargo llvm-cov --package <crate> --fail-under-lines 95)cargo test -p credence_bond fuzz::test_bond_fuzz -- --nocapture)cargo test -p credence_errors error_codes_wire)cargo build --release)Checklist
CHANGELOG.mdupdated (ifcontracts/**touched)<type>/<short-description>naming conventionAdditional Context
This addresses the strict requirement to verify exact integer rules at every boundary, blocking anomalous
PauseSignerCountmodifications and preventing any durable authority from being incorrectly persisted.