fix(admin): revalidate ownership transfer candidates - #1300
Merged
Baskarayelu merged 3 commits intoAug 29, 2026
Merged
Conversation
|
@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1296
Description
Revalidates ownership-transfer candidates immediately before ownership is written. A pending candidate that becomes deactivated, suspended, removed, or demoted during the timelock can no longer accept ownership.
Adds integration-boundary rollback regression tests confirming failed acceptance leaves the owner, pending owner, and event stream unchanged. Documents the atomicity invariant and compatibility impact.
Type of Change
How Has This Been Tested?
cargo test --workspacepassescargo fmt -p admin -- --checkpassescargo clippy --workspace --all-targets --all-features -- -D warningspassescargo llvm-cov --package <crate> --fail-under-lines 95)cargo test -p credence_bond fuzz::test_bond_fuzz -- --nocapture)cargo test -p credence_errors error_codes_wire)cargo build --release)cargo test -p adminwas attempted but blocked before compiling the admin crate by an existing dependency-resolution conflict insoroban-env-hostinvolving incompatiblerand_coreversions.Checklist
CHANGELOG.mdupdated<type>/<short-description>naming conventionAdditional Context
Compatibility: no public API, response-shape, storage-layout, or migration changes. Acceptance now rejects an otherwise pending ownership transfer if its candidate is no longer an active, unsuspended
SuperAdmin.Security/correctness: all eligibility checks execute before the first ownership write. A rejected acceptance therefore preserves the current owner, pending proposal, proposal timestamp, and event stream atomically.