fix(credence_bond): enforce fee bounds and emit old/new values - #1256
Open
sudo-robi wants to merge 2 commits into
Open
fix(credence_bond): enforce fee bounds and emit old/new values#1256sudo-robi wants to merge 2 commits into
sudo-robi wants to merge 2 commits into
Conversation
…nceOrg#1027) - fees: gate [MIN/MAX]_FEE_BPS=[0,1000] (10%); panic with "fee_bps out of bounds". - fees/events: emit fee_config_updated(admin, old_treasury, new_treasury, old_fee_bps, new_fee_bps). - lib: add set_fee_config/get_fee_config entrypoints + DataKey::{FeeTreasury, FeeBps}. - test: bounds at MIN/MAX boundaries, MAX+1 rejected, event payload assertions, re-emit on no-op. - errors: pre-req ContractError::RoleRequired = 128 variant + category/is_recoverable arms (lands CredenceOrg#1235 dependency). - docs: fees.md + EVENTS.md mirror the new bounds and event shape. - baseline: panic_baseline.txt picks up fees.rs::panic!("fee_bps out of bounds"). Closes CredenceOrg#1027
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #279