feat(outbox): harden publish contract with crash-safe idempotency keys - #1219
Merged
Baskarayelu merged 1 commit intoJul 29, 2026
Merged
Conversation
Adds integration tests for crash-safe outbox publish contract and idempotent consumer keys. Closes CredenceOrg#945
|
@Banx17 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR hardens the outbox publish contract with crash-safe idempotency keys and comprehensive integration tests. The existing outbox infrastructure (publish idempotency key, lease-based crash recovery, IdempotentConsumer) is already in place - this PR adds integration-level coverage that simulates real crash scenarios to verify the guarantees hold end-to-end.
Related Issue
Closes #945
Changes
Crash-Safe Outbox Integration Tests
Idempotent Consumer Key Tests
Verification Results
npm test src/db/outbox/ tests/integration/outboxCrashRecovery.integration.test.ts
63/63 passed (46 existing + 17 new)
Test Files 7 passed (7)
Tests 63 passed (63)