Fix ClassCastException in PhysicsAssemblerGUIHandler - #1098
Merged
Ocelot5836 merged 1 commit intoMay 21, 2026
Conversation
… with the assembler while a ghost block is at its position
There was a problem hiding this comment.
Pull request overview
This PR fixes a client crash (ClassCastException) in the physics assembler hold interaction by removing an unsafe cast when reading the block entity at the interaction position, which can temporarily be a different/ghost block entity during rapid assemble/disassemble.
Changes:
- Replaced a direct cast of
getBlockEntity(...)toPhysicsAssemblerBlockEntitywith aninstanceofcheck to safely handle null/other block entities.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ocelot5836
merged commit May 21, 2026
c641757
into
Creators-of-Aeronautics:main
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ClassCastException in PhysicsAssemblerGUIHandler when interacting
with the assembler while a ghost block is at its position.
Encountered this bug when testing ryanhcode/sable#966 lol
Steps to reproduce: