feat(royalties): implement multi-recipient royalty splits for collaborative beats (#8) - #25
Open
Simultech369 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request resolves #8 by implementing multi-recipient royalty splits for collaborative beats, allowing beatmakers, vocalists, songwriters, and mixing engineers to automatically split on-chain license sales.
🎯 Key Implementations
Contract Interfaces & Split Math (
src/contracts/crate.ts)RoyaltySplitinterface (recipient,bps: basis points where 10,000 bps = 100%,role).validateSplitshelper enforcing 100% sum allocation (10,000 bps) and valid recipient addresses.calculateSplitPayoutshelper calculating pro-rata revenue allocations across collaborators while deterministically attributing fractional remainders to eliminate rounding drift.SampleDataanduploadSamplewithsplits?: RoyaltySplit[].Upload UI with Dynamic Collaborator Splitting (
src/pages/Upload.tsx)Sample Detail & Profile Integration (
src/pages/SampleDetail.tsx,src/pages/Profile.tsx)SampleDetail.tsx: Displays collaborative royalty splits breakdown with role badges, recipient abbreviations, and percentage shares.Profile.tsx: Displays individual contributor royalty shares and earnings on collaborative tracks, supporting per-collaborator withdrawal tracking.Comprehensive Unit Tests (
src/__tests__/royaltySplits.test.tsx)🧪 Verification & Testing
npx vitest run: