feat: Enhance MultiSigContractV2 storage with transaction tracking mappings and Natspec #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces several important storage improvements to
MultiSigContractV2to better track transactions, their signers, and signatures. These changes are aimed at improving transparency, auditability, and developer understanding of the contract.Changes:
Add Storage Natspec Header
Add
transactionsMappingmapping(uint256 => TransactionData) private transactions;Add
hasSignedTransactionMappingmapping(uint256 => mapping(address => bool)) public hasSignedTransaction;Add
transactionSignersMappingmapping(uint256 => address[]) public transactionSigners;Add
transactionSignaturesMappingmapping(uint256 => address[]) public transactionSignatures;Code Formatting
forge fmtfor consistent styling and readability.Motivation:
These updates are foundational for enabling a more robust multi-signature workflow. By explicitly tracking transaction signers and signatures, we ensure:
Files Updated:
src/MultiSigContractV2.sol– Added new mappings and Natspec header, applied formatting.Notes: