Skip to content

Conversation

@SynnekOG
Copy link

@SynnekOG SynnekOG commented Oct 1, 2025

PR Description

Summary

This PR introduces a new SignerInfo struct into MultiSigContractV2.sol to provide a standardized way of tracking metadata and activity related to individual signers. This is a foundational change that lays the groundwork for more robust signer management, governance, and auditing features in future updates.

Changes

  • Added SignerInfo struct with the following fields:

    • bool active: Indicates if a signer is currently active.
    • uint256 addedAt: Timestamp of when the signer was added.
    • uint256 lastSignedAt: Timestamp of the most recent transaction the signer approved.
    • uint256 totalSigned: Number of transactions signed by this signer.
    • string role: Logical role assigned to the signer (e.g., admin, auditor, member).
    • uint256 reputation: Numeric score for evaluating signer trustworthiness or performance.
  • Formatting

    • Applied forge fmt for codebase consistency.

Rationale

  • Provides a flexible data model for managing and evaluating signers.
  • Improves transparency by tracking signer activity and contributions.
  • Enables role-based responsibilities and potential governance layers.
  • Establishes a reputation system to help with accountability and trust metrics.

Impact

  • No breaking changes to existing contract functionality.
  • Sets up the foundation for role-based access control, advanced signer auditing, and potential slashing/reward mechanisms in later iterations.

Next Steps

  • Integrate SignerInfo into signer management functions (add/remove/update).
  • Implement role-based restrictions and checks.
  • Utilize reputation in decision-making and voting weight mechanics.

@2PykeETH 2PykeETH self-requested a review October 1, 2025 18:17
@2PykeETH 2PykeETH added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 1, 2025
@2PykeETH 2PykeETH merged commit a99ce3f into CraftMeme:main Oct 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants