feat: Add Custom Errors for Signer Management and Signature Validation in MultiSigContractV2 #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances
MultiSigContractV2by introducing new custom errors related to signer management and signature validation. These errors strengthen the security, auditability, and maintainability of multisignature operations, while improving gas efficiency compared to string-based reverts.Changes
src/MultiSigContractV2.solAdded 4 new custom errors:
MultiSigContract__SignerAlreadyExistsRaised when attempting to add a signer that is already part of the multisig group.
MultiSigContract__SignerNotFoundThrown when an operation references a signer that does not exist in the multisig group.
MultiSigContract__InsufficientSignaturesRaised if a transaction does not have enough valid signatures to meet the quorum requirement.
MultiSigContract__InvalidAddressPrevents use of invalid or zero addresses in critical signer-related operations.
Ran
forge fmtto apply consistent formatting across the contract.Motivation
Next Steps
addSigner,removeSigner,replaceSigner) and transaction execution logic.