feat: Add Additional Custom Errors for MultiSigContractV2 #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances
MultiSigContractV2with new custom error definitions to improve transaction validation, debugging clarity, and gas efficiency compared to traditionalrequirestrings. These errors provide precise failure reasons in multisignature transaction flows.Changes
src/MultiSigContractV2.solAdded 5 new custom errors:
MultiSigContract__NotSignedThrown when a signer attempts to execute or finalize a transaction without having signed it.
MultiSigContract__InvalidTransactionRaised if the transaction does not meet validity checks (e.g., malformed or nonexistent).
MultiSigContract__TransactionExpiredEnsures transactions past their expiration window cannot be executed.
MultiSigContract__TransactionNotReadyIndicates an attempt to execute a transaction before required conditions (e.g., sufficient signatures) are met.
MultiSigContract__InvalidSignerCountPrevents execution if signer count is below quorum or exceeds allowable thresholds.
Ran
forge fmtto enforce consistent formatting.Motivation
Next Steps
propose,sign,execute).