feat: add modifiers with validation and access control to LiquidityManagerV2 #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This PR introduces a set of reusable modifiers in
LiquidityManagerV2to enforce stricter validation, access control, and safety checks across liquidity management functions.Changes
Modifierssection with NatSpec header for clarity and organization.onlyFactory: restricts function calls to the factory contract.validTokenPair: ensures both token addresses are valid and distinct.onlySupportedTokens: restricts operations to supported token pairs.validAmount: checks that provided amounts are greater than zero.deadlineCheck: enforces deadlines to mitigate stale transactions.forge fmtfor consistent code style.Motivation
Modifiers reduce code duplication and make function-level validation more readable and maintainable.
They ensure:
Next Steps
addLiquidity,removeLiquidity,initializePool, etc.).