v1.4 canfar run #690
Open
v1.4 canfar run #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove 000.000
Canfar job limit
…eline job description to docs/source
monitoring
Mask runner skip processing if output file exists
Docker image
…us runs for =j 128
martinkilbinger
commented
Jan 15, 2025
shapepipe/modules/make_cat_runner.py
Outdated
| shape1_cat_path, | ||
| ) = input_file_list | ||
| sexcat_sm_path = None | ||
| else: |
There was a problem hiding this comment.
New: spread model input is optional
martinkilbinger
commented
Jan 15, 2025
| sexcat_sm_path, | ||
| SEx_catalogue=True, | ||
| ) | ||
| sexcat_sm_file.open() |
There was a problem hiding this comment.
spread model input is not optional
martinkilbinger
commented
Jan 15, 2025
| @@ -1180,7 +1188,15 @@ def _build_final_mask( | |||
| external_flag.open() | |||
| if final_mask is not None: | |||
| final_mask = final_mask.astype(np.int16, copy=False) | |||
| final_mask += external_flag.get_data()[:, :] | |||
| try: | |||
There was a problem hiding this comment.
Added file check
martinkilbinger
commented
Jan 15, 2025
| open_mode=file_io.BaseCatalogue.OpenMode.ReadWrite, | ||
| SEx_catalogue=True | ||
| SEx_catalogue=False, |
There was a problem hiding this comment.
Propagating information from original catalogue (True) is not needed, and moves the main data to HDU #2, not compatible with other files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major modifications for processing run on canfar of ShapePipe v1.4 catalogues.
Auxilliary scripts:
Main pipeline:
Modules:
processing is interrupted, reprocessing does not have to start from the beginning. Note that in this case the random numbers
do not match the previous object ID any more.
check_existing_diroption to modules mask, ngmix. Processing of the corresponding module is skipped ifexpected output file exists in this directory.
Reviewer Checklist
developbranch