feat: Add IBCv2 timeout entrypoint #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
force-pushed
the
tkulik/feat/ibc_timeout
branch
from
2ae76bb to
0a1044b
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_timeout
branch
from
0a1044b to
b793e42
Compare
OK, so hear me out.... This would be much better -- it is already good -- if the unmanaged vectors were safer. |
kulikthebird
requested review from
chipshort and
jawoznia
and removed request for
chipshort
kulikthebird
force-pushed
the
tkulik/feat/ibc_timeout
branch
from
4958b47 to
2fe1347
Compare
jawoznia
approved these changes
Apr 25, 2025
| @@ -164,11 +163,10 @@ func AnalyzeCode(cache Cache, checksum []byte) (*types.AnalysisReport, error) { | |||
| requiredCapabilities := string(copyAndDestroyUnmanagedVector(report.required_capabilities)) | |||
| entrypoints := string(copyAndDestroyUnmanagedVector(report.entrypoints)) | |||
| entrypoints_array := strings.Split(entrypoints, ",") | |||
| hasIBC2EntryPoints := slices.Contains(entrypoints_array, "ibc2_packet_receive") | |||
That's interesting. It's always good to emphasise security and reliability. At the same time it's not in scope of this PR. Definitely something that should be discussed in the second half of the year. |
|
Yeah I'm really sorry for invading this PR with that - except like, I have to disagree with this:
The input validation stuff is, in my opinion, and again, my apologies for jumping into this PR, and note I'll gladly delete this after it's seen, um, quite pressing. Thank you. |
kulikthebird
force-pushed
the
tkulik/feat/ibc_timeout
branch
from
2fe1347 to
71df726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.