Skip to content

refactor: use slices.Contains to simplify code #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CoolCu
Copy link

@CoolCu CoolCu commented Apr 28, 2025

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.95%. Comparing base (0f448be) to head (63b9084).

Files with missing lines Patch % Lines
x/wasm/types/params.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
- Coverage   45.97%   45.95%   -0.03%     
==========================================
  Files          78       78              
  Lines       10677    10667      -10     
==========================================
- Hits         4909     4902       -7     
+ Misses       5331     5328       -3     
  Partials      437      437              
Files with missing lines Coverage Δ
x/wasm/migrations/v2/params_legacy.go 68.11% <100.00%> (-0.46%) ⬇️
x/wasm/types/json_matching.go 92.30% <100.00%> (-0.55%) ⬇️
x/wasm/types/types.go 59.56% <100.00%> (-0.70%) ⬇️
x/wasm/types/params.go 73.07% <66.66%> (+2.34%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant