Skip to content

chore: Deprecate IBC fees #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025
Merged

Conversation

kulikthebird
Copy link
Member

@kulikthebird kulikthebird commented Mar 19, 2025

Closes #2419

@kulikthebird kulikthebird self-assigned this Mar 19, 2025
@kulikthebird kulikthebird linked an issue Mar 19, 2025 that may be closed by this pull request
@kulikthebird kulikthebird changed the base branch from main to release/2.2 March 19, 2025 15:44
@kulikthebird kulikthebird force-pushed the tkulik/chore/deprecate_ibc_fees branch from d3a1ebf to 093e594 Compare March 20, 2025 07:43
@aumetra
Copy link
Member

aumetra commented Mar 20, 2025

Was just missing an #[allow(deprecated)], should all work fine now :D

@aumetra aumetra force-pushed the tkulik/chore/deprecate_ibc_fees branch from 8e2633d to 7963497 Compare March 20, 2025 10:18
@aumetra
Copy link
Member

aumetra commented Mar 20, 2025

(check #2083 for a precedent where we just blanket allowed usage of deprecated APIs in a module because of the weird interaction in enums)

Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a CHANGELOG entry :P

@kulikthebird kulikthebird force-pushed the tkulik/chore/deprecate_ibc_fees branch from 882315e to 4681714 Compare March 20, 2025 13:43
@kulikthebird kulikthebird requested a review from aumetra March 20, 2025 13:44
@aumetra aumetra merged commit 10242fd into release/2.2 Mar 20, 2025
38 checks passed
@aumetra aumetra deleted the tkulik/chore/deprecate_ibc_fees branch March 20, 2025 14:24
@aumetra
Copy link
Member

aumetra commented Mar 21, 2025

Yeah, gonna pull this to main, too

@aumetra
Copy link
Member

aumetra commented Mar 21, 2025

@Mergifyio backport main

Copy link
Contributor

mergify bot commented Mar 21, 2025

backport main

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Depracate IBC fees
2 participants