New mock_environment function with valid contract address
#2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipshort
commented
Aug 16, 2024
| @@ -89,6 +103,20 @@ pub fn mock_dependencies_with_balances( | |||
| } | |||
| } | |||
|
|
|||
| /// Initializes the querier along with the mock_dependencies. | |||
| /// Sets all balances provided (you must explicitly set contract balance if desired). | |||
| pub fn mock_dependencies_with_balances_valid( | |||
There was a problem hiding this comment.
This name is more of a placeholder because I couldn't come up with a good one.
Any ideas?
I see, not great. How do you feel about #2217 as an 80/20 solution and recommend advanced users to have their own version of |
|
Closing here for now, since we'll postpone to 3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an attempt at #2211
Problem is that this requires massive refactoring when changing existing tests. The borrow checker bites you whenever you use
mock_environment(&deps.api)inside a call where you also passdeps, so you need to create the env first and then pass it to the function.mock_dependencies_with_balancesandmock_dependencies_with_balanceare also affected by the invalid address problem and got new variants here too.