fix(prism): queue submits when lium b200s sell out - #176
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughLium capacity failures now use dedicated classification and recovery behavior. Affected submissions remain queued, do not consume retry attempts, record capacity details, and expose the policy through API responses and documentation. Authentication, permission, ZIP, and other non-capacity failures remain terminal. ChangesLium capacity recovery
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SubmissionAPI
participant Orchestrator
participant LiumRentPool
participant PrismStore
SubmissionAPI->>Orchestrator: Process queued submission
Orchestrator->>LiumRentPool: Classify provisioning failure
LiumRentPool-->>Orchestrator: Return no_capacity
Orchestrator->>PrismStore: Requeue without consuming retry
Orchestrator-->>SubmissionAPI: Return queued status and capacity note
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_capacity/ sold-out / no matching 1× B200 offer requeues the submission (noretry_countburn, not Score(0)) instead of failing closed.error_detail; intake +GET /v1/statuscarry the queue policy).claim_nexttick retries rent; failed sold-out rows are recovered by the existing 429 recovery loop.Test plan
no_capacity→ staysqueued+ B200 note; second tick still queuedfailed(auto_retry_max: 0)202includes capacity policynote;/v1/statushaslium_capacity_noteSummary by CodeRabbit
New Features
lium_capacity_note.Bug Fixes
Documentation