WIP cleanup finlattice.v #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi8027
commented
Jan 26, 2023
src/finlattice.v
Outdated
Comment on lines
456
to
424
| Definition fmeet (S : finLattice) := (premeet L S). | ||
| Definition fjoin (S : finLattice) := (prejoin L S). | ||
| Definition fmeet (S : finLattice) := premeet L S. | ||
| Definition fjoin (S : finLattice) := prejoin L S. |
There was a problem hiding this comment.
Turning the prelattice structure into a bundled structure would allow us to remove these fmeet and fjoin.
pi8027
commented
Feb 6, 2023
src/finlattice.v
Outdated
| Module Exports. | ||
| Coercion base : class_of >-> Order.POrder.class_of. | ||
| Coercion mixin : class_of >-> mixin_of. | ||
| Coercion class : type >-> class_of. |
There was a problem hiding this comment.
Usually class is not a coercion.
|
Shall we merge and continue on the coq_8_16 branch? |
|
Ah, but I guess I have no write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelOrdershould not be imported.S : {fset T}.finLatticeto split the Boolean conjunction into three fields. Defining itssubTypeinstance becomes a bit tricky, but I managed to do that.