Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/swagger docs #9

Merged
merged 6 commits into from
Jul 8, 2023
Merged

ci/swagger docs #9

merged 6 commits into from
Jul 8, 2023

Conversation

a20688392
Copy link
Collaborator

@a20688392 a20688392 commented Jun 25, 2023

Setup integrate SwaggerHub with GitHub, generate swagger file on SwaggerHub.

Use SwaggerHub CLI

SwaggerHub CLI link

  • Set Actions secrets and variables
    • SWAGGERHUB_API_KEY:use API Key for swaggerhub authentication.

Execution conditions

Version

Version according to package.json

In PR

@a20688392 a20688392 requested a review from moontai0724 June 25, 2023 11:09
Copy link
Member

@moontai0724 moontai0724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a big mistake. LOL

@a20688392 a20688392 requested a review from moontai0724 July 1, 2023 11:33
@a20688392 a20688392 enabled auto-merge (squash) July 1, 2023 12:35
Copy link
Member

@moontai0724 moontai0724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments above

a20688392 added 3 commits July 2, 2023 04:30
why need? In order to achieve automatic, swagger docs change will follow the commit hash.

create will generate new swagger docs.
update will update specified version information.
@a20688392 a20688392 requested a review from moontai0724 July 3, 2023 10:13
@a20688392 a20688392 force-pushed the ci/swagger-docs branch 2 times, most recently from 7806d80 to 0a56db0 Compare July 5, 2023 07:55
Copy link
Member

@moontai0724 moontai0724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but it would be better if you reply the swagger url to the PR

@a20688392 a20688392 merged commit 35d1f22 into develop Jul 8, 2023
@a20688392 a20688392 deleted the ci/swagger-docs branch July 8, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants