Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables all eslint rules, with following modifications:
Disabled Rules (required)
no-magic-numbers
: this will wrongly detect a number passed to a function as a magic number.new-cap
: the decorators will be wrongly detectedclass-methods-use-this
: some methods are not using thisDisabled Rules (optional, in personal preference)
no-console
: this will disable console.log, console.error, etc. This could be removed if we have our own logger.one-var
: I prefer to not merge variables to single annotation.no-continue
: preseve the possibility to use continue in loops.Replaced Rules
no-useless-constructor
: replaced by@typescript-eslint/no-useless-constructor
to support typescript dummy variable annountation.no-shadow
: replaced by@typescript-eslint/no-shadow
to better handle with typescript only types.sort-imports
: replaced byimport
andsimple-import-sort
to auto sort imports.Attitional Rules
@typescript-eslint/consistent-type-imports
: announce imports as type only import if not using its value.padding-line-between-statements
: to separete statments to enhance readability.TypeScript ESLint Rules
This PR also enables all TypeScript ESLint rule but disabled some rules due to those rules are too strict. For detail, see
.eslintrc.json#L41-L50