New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/local register #7

Merged

a20688392 merged 30 commits into develop from feature/local-register

Jun 10, 2023

Collaborator

a20688392 commented Jun 4, 2023 •

edited

Loading

本地使用者註冊和單元測試

本地使用者註冊：
- 初始化資料庫表、註冊API、驗證資料格式
- 單元測試
  - auth controller
    - 驗證資料格式和回應訊息
  - auth service
    - 驗證資料衝突和回應訊息
  - user service
    - 驗證資料衝突和回應訊息
新增 dataSourceJest 是因為單元測試吃的是 TS
- feat: auth service unit test
package.json 修改 jest參數和新增 sqllite3
- 測試時使用 sqlite在記憶體中使用
  - test: 將測試資料庫改成 sqlite
- 會顯示全部詳細測試資訊
  - "test": "jest --verbose",
- 為了讓他能在 jest 單元測試抓到路徑，原本只能抓相對路徑
- 範例：src/users/entities/user.entity

"moduleNameMapper": {
      "src/(.*)$": "<rootDir>/$1"
}

a20688392 added 14 commits

June 3, 2023 01:19


          feat: 全域驗證器默認設定

f66279f


          feat: 使用者資料表初始化

cfbfb42


          feat: 使用者註冊驗證

20d10f6


          feat: 使用者註冊資料儲存

539f8d6


          feat: 使用者註冊密碼加密

154dcce


          feat: 使用者註冊 swagger demo

598f153


          feat: 使用者註冊加上回應狀態

dcc4c9e


          test: auth service unit test

2a24498


          test: auth controller 單元測試-dto資料驗證

75afc68


          test: auth controller 單元測試-創建本地使用者201回應

dd188b1


          test: auth controller 單元測試-創建本地使用者資料驗證失敗406回應

ac250a9


          test: auth controller 單元測試-providers 資料庫命名錯誤修正

561c7c5


          test: auth controller 單元測試-創建本地使用者資料重覆失敗409回應

147bdd4


          test: auth service 單元測試加上測試後復原資料庫

6acb3ea

a20688392 requested a review from moontai0724

June 4, 2023 15:11


          test: 將測試資料庫改成 sqlite

ffd8019

a20688392 force-pushed the feature/local-register branch from 96b1801 to ffd8019 Compare

June 4, 2023 16:26

moontai0724 reviewed

View reviewed changes

src/auth/auth.service.spec.ts Outdated Show resolved Hide resolved

src/auth/auth.service.spec.ts Outdated Show resolved Hide resolved

src/auth/auth.service.spec.ts Outdated Show resolved Hide resolved

src/auth/auth.service.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/auth/auth.service.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/auth/auth.service.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/dto/create-user.dto.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/entities/user.entity.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/exceptions/create-user-badrequest-error.exception.ts Outdated Show resolved Hide resolved

src/users/exceptions/create-user-conflict-error.exception.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/exceptions/create-user-conflict-error.exception.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/users.module.ts Outdated Show resolved Hide resolved

src/users/users.service.spec.ts Outdated Show resolved Hide resolved

src/users/users.service.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/users.service.spec.ts Outdated Show resolved Hide resolved

moontai0724 reviewed

View reviewed changes

src/users/users.service.ts Outdated Show resolved Hide resolved

moontai0724 requested changes

View reviewed changes

Member

moontai0724 left a comment

Comments above.

moontai0724 assigned a20688392

a20688392 added 9 commits

June 6, 2023 23:17


          test: 將 afterEach 搬移至最後面並只需要一次

af03407


          fix: 將非此次測試的刪除

d6efa65


          fix: 修正狀態碼 406->400

24c0968


          refactor: 將 createAt 改成 createdAt

3a422bf


          fix: 範例訊息移除 name 的重複衝突

7a8ebd3


          test: usersService 單元測試-創建使用者

ca5cdce


          refactor: 將 try catch 移除


          refactor: 更改為使用 hashSync

1718f03


          refactor: 使用單數 user

b9f0972

a20688392 force-pushed the feature/local-register branch from 00bf9e6 to b9f0972 Compare

June 8, 2023 14:25


          fix: auth controller 單元測試-重新撰寫是否會正確驗證傳入的 payload

f33bcc6

a20688392 requested a review from moontai0724

June 8, 2023 14:44

Collaborator Author

a20688392 commented Jun 8, 2023

修復完了

moontai0724 requested changes

View reviewed changes

Member

moontai0724 left a comment

Tests should not contain external tests that are not related to test target exposed interfaces

moontai0724 reviewed

View reviewed changes

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved

a20688392 added 2 commits

June 9, 2023 00:47


          refactor: 將 DTO 驗證搬移出去

039491a


          refactor: 將自定義的 validationPipe 獨立出來

29f3558

a20688392 requested a review from moontai0724

June 8, 2023 16:53

moontai0724 approved these changes

View reviewed changes

src/pipe/validation-pipe.ts Outdated Show resolved Hide resolved

src/user/dto/create-user.dto.spec.ts Outdated Show resolved Hide resolved

src/user/dto/create-user.dto.spec.ts Outdated Show resolved Hide resolved

moontai0724 approved these changes

View reviewed changes

Member

moontai0724 left a comment

Well done!

a20688392 added 3 commits

June 10, 2023 15:39


          refactor: 應使用 pips 命名資料夾

e572da2


          refactor: 刪除多餘命名

8abcc3b


          refactor: 驗證 dto 使用自訂 validation-pipe

72289d5

a20688392 requested a review from moontai0724

June 10, 2023 07:52

moontai0724 approved these changes

View reviewed changes

Member

moontai0724 left a comment

Well done!

a20688392 merged commit 2f13ea2 into develop

a20688392 deleted the feature/local-register branch

June 10, 2023 07:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet