feat: Setup local user register & handle exception error to logger #6
Conversation
|
|
||
| import { AppModule } from "./app.module"; | ||
|
|
||
| async function bootstrap() { | ||
| const app = await NestFactory.create(AppModule); | ||
| app.use(morgan("default", { stream: logStream })); |
There was a problem hiding this comment.
does not described in PR content, should consider to add description about this
src/main.ts
Outdated
| setupSwagger(app); | ||
| await app.listen(3000); | ||
| } | ||
|
|
||
| const logStream = fs.createWriteStream("api.log", { |
There was a problem hiding this comment.
does this mean to log into single file in root folder? I would recommend to reconsider about log file save path and segmentation policy like by size or by date etc...
There was a problem hiding this comment.
- generaly we would use
modelto represent database models, to use this word here would be confusing. - I would recommend to reconsider how to organize these files, like use a
exception-filterto organizeall-exceptionsand this type together.
| description: "Data Conflict", | ||
| type: CreateConflictUserError, | ||
| }) | ||
| @ApiUnprocessableEntityResponse({ |
There was a problem hiding this comment.
generally will use 401 instead of 422 to represent that user given data is not correct.
|
|
||
| @ApiProperty({ | ||
| description: "User showname", | ||
| example: "showname", |
There was a problem hiding this comment.
it would be better to use a name or something
| }, | ||
| }, | ||
| }, | ||
| example: "email has been registered.", |
There was a problem hiding this comment.
should be an array of message
There was a problem hiding this comment.
I recommend to create an auth module to handle register, login related features.
ref:
a20688392
force-pushed
the
feature/localuser-register
branch
from
cc2fab5 to
0f4a61d
Compare
Setup local user register, handle exception error, and setup logger
Setup：