Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coin-tester): viteCommonjs should skipPreBuild #272

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix(coin-tester): viteCommonjs should skipPreBuild #272

merged 1 commit into from
Feb 11, 2022

Conversation

hank121314
Copy link
Contributor

@hank121314 hank121314 commented Feb 11, 2022 •
edited
Loading

Summary

Package @coolwallet/xml use stellar-sdk which is using es6-promise.
es6-promise inline require vertx package.
If vite-common-js will transform all inline require to global require , it will cause some issues.

Reference

originjs/vite-plugins#17

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hank121314 hank121314 merged commit dadefc7 into master Feb 11, 2022
@hank121314 hank121314 deleted the fix/CWC-393-coin-tester-vertx branch February 11, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hankliu418 hankliu418 hankliu418 approved these changes

@skchang0710 skchang0710 skchang0710 approved these changes

@srt1678 srt1678 Awaiting requested review from srt1678

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hank121314 @skchang0710 @hankliu418