fix: replace require() with ESM import in skills loader#207
Open
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Open
fix: replace require() with ESM import in skills loader#207haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Conversation
checkRequirements() uses require("child_process") inside the function
body (line 107). Since the project uses "type": "module", require() is
not available at runtime and throws ReferenceError. This silently
breaks skill requirement checks — every skill with a `requires.bins`
field is skipped because the error is caught on line 78.
Move to a top-level ESM import so execFileSync is available at runtime.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkRequirements()inskills/loader.tscallsrequire("child_process")inside the function body"type": "module",require()is not available at runtime and throwsReferenceErrortry/catchon line 78, causing every skill with arequires.binsfield to be skipped — binary requirement checks never actually runFix
execFileSyncto a top-level ESMimportstatement (consistent with howskills/registry.tsalready imports it)require()callTest plan
npx tsc --noEmitpasses (confirmed locally)requires.bins: ["node"]and verify it loads correctlyrequires.bins: ["nonexistent_binary"]and verify it is skipped