fix: enforce HTTPS in ResilientHttpClient to prevent cleartext credential transmission (CWE-319)#185
Open
quangtran88 wants to merge 1 commit intoConway-Research:mainfrom
Open
Conversation
…tial transmission (CWE-319) Reject non-HTTPS URLs in the request method, with an exception for localhost/127.0.0.1 for local development. Prevents API keys sent in Authorization headers from being transmitted in cleartext. Closes Conway-Research#182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject non-HTTPS URLs in
ResilientHttpClient.request()to prevent API keys and other credentials from being transmitted in cleartext.Changes
request()before any network I/Ohttps:, with an exception forlocalhostand127.0.0.1for local developmentRefusing to send request over insecure protocol: http: (use HTTPS)Security Impact
The
ResilientHttpClientpreviously accepted any URL protocol. Since it's used for all Conway API calls — which include the API key in theAuthorizationheader — anhttp://URL would transmit credentials in cleartext, exposing them to network-level attackers (MITM, packet sniffing).Test Compatibility
All existing tests already use
https://URLs — no test changes required.Closes #182